Comments for Daniel Wertheim

Comment on C#, Generic factory with support for private constructors by Real Exams

Real Exams — Tue, 24 Jan 2012 07:50:22 +0000

There are certainly new points to learn. thanks a lot.

Comment on PineCone project by Elegant Code » NuGet Project Uncovered: PineCone

Elegant Code » NuGet Project Uncovered: PineCone — Tue, 24 Jan 2012 00:19:04 +0000

[...] found a description from a blog post for this project: PineCone lets you take a C# class and then builds a schema for this class. This [...]

Comment on Why the ExpectedExceptionAttribute sucks! by Daniel Wertheim

Daniel Wertheim — Fri, 20 Jan 2012 09:52:46 +0000

Hi Joey,
Hope I can clarify.

PlaceBid_WhenNoBidsExists_BidIsAdded
Nothing to comment

PlaceBid_WhenHigherBidExists_ThrowsInvalidOperationException
Bid 1: 10
Bid 2: 5 –> InvalidOperationException

PlaceBid_WhenBidIsLowerThan5_ThrowsInvalidOperationException
Bid 1: 4 –> InvalidOperationException

Update
PlaceBid_WhenBidIsLowerThan5_ThrowsInvalidOperationException

PlaceBid_WhenBidIsLowerThan10_ThrowsInvalidOperationException
Bid 1: 9 –> InvalidOperationException

All tests passes at this point while test: “PlaceBid_WhenHigherBidExists_ThrowsInvalidOperationException” should fail. Why? Since it should test InvalidOperationException caused by higher bid exists not InvalidOperationException caused by to low bid. Hence this test should be updated to, lets say: Bid 1 “15″ and Bid 2 “10″. It will still pass, but this time since 10 is lower than 15. That’s the point. ExpectedException can not isolate a single line.

//Daniel

Comment on C#, Why params object[] should be forbidden! (v2) by Daniel Wertheim

Daniel Wertheim — Fri, 20 Jan 2012 09:44:37 +0000

The difference lied in params int[] vs params object[], but I've rewritten the post since I first wrote it in anger/frustration. I hope it is more clear now. //Daniel

Comment on C#, Why params object[] should be forbidden! (v2) by Daniel Wertheim

Daniel Wertheim — Fri, 20 Jan 2012 09:43:12 +0000

I’ve rewritten the post since I first wrote it in anger/frustration. I hope it is more clear now.

//Daniel

Comment on C#, Why params object[] should be forbidden! (v2) by Arthur

Arthur — Thu, 19 Jan 2012 21:46:33 +0000

Unless I need new glasses I do not see any difference in code Daniel

Comment on Why the ExpectedExceptionAttribute sucks! by Joey

Joey — Thu, 19 Jan 2012 13:31:39 +0000

I don´t agree with the conclusion you´re drawing from the final example.
You tell the code to check if the value you try to enter, is < 10. If that's the case, you throw the exception.
After that happens, you check if the bid is lower than what has already been bid.

In my eyes, the code shouldn't give the 'bid is lower than other bid' at all, because the value you're trying to bid is invalid in the first place.

So the reason the test fails, is because you expect an Exception to be thrown, that shouldn't be thrown in this particular case.

tl;dr:
The code in your example should correctly throw the 'bid < 10' Exception. It does this, but you expect another exception.

p.s. Don't get me wrong, MSTest has it's shortcomings, it's not perfect at all. But I just couldn't agree with this particular example.

//J

Comment on C#, Why params object[] should be forbidden! (v2) by Kim Tranjan

Kim Tranjan — Wed, 18 Jan 2012 23:26:06 +0000

Do you mean “Change: params object[] to object”?

Comment on C#, Why params object[] should be forbidden! (v2) by Kim Tranjan

Kim Tranjan — Wed, 18 Jan 2012 23:22:00 +0000

Sorry, I don’t get it…

Comment on SisoDb v9.0 Released. by Daniel Wertheim

Daniel Wertheim — Wed, 18 Jan 2012 20:05:10 +0000

That’s a great suggestion.